Page MenuHomePhabricator

Support Spaces in Diffusion
ClosedPublic

Authored by epriestley on Jun 24 2015, 1:18 PM.

Details

Reviewers
btrahan
Maniphest Tasks
T8493: Integrate Spaces into more applications
Commits
Restricted Diffusion Commit
rPfcb35a55fd23: Support Spaces in Diffusion
Summary

Ref T8493. Diffusion is probably the strongest upstream use case we have for Spaces right now, so I want to get us on it to kick the tires a bit.

Small amount of hackiness around the multi-page form thing but it shouldn't create any problems.

Test Plan
  • Created a new repo.
  • Edited a repo.
  • Tried invalid edits, saw value preserved.
  • Viewed edit full detail screen, saw space info.
  • Viewed repo detail view, saw space.
  • Viewed repo list view, saw space.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support Spaces in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2015, 4:21 PM
This revision was automatically updated to reflect the committed changes.

How does this work with callsigns? They still must be globally unique I presume?

Yes. Project names, callsigns, usernames, etc., all still need to be globally unique.