Show when objects have a non-default policy
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 3:28 AM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6787: Clarify UI for Objects with a non-default Policy

Commits

Restricted Diffusion Commit
rPd1983560a6bc: Show when objects have a non-default policy

Summary

Fixes T6787. I'm kind of cheating a little bit here by not unifying default selection with initializeNew(...) methods, but I figure we can let this settle for a bit and then go do that later. It's pretty minor.

Since we're not doing templates I kind of want to swap the 'template' key to 'type' so maybe I'll do that too at some point.

@chad, freel free to change these, I was just trying to make them pretty obvious. I do think it's good for them to stand out, but my approach is probably a bit inconsistent/heavy-handed in the new design.

Test Plan

Screen Shot 2015-06-21 at 8.17.08 PM.png (955×1 px, 177 KB)

Screen Shot 2015-06-21 at 8.16.51 PM.png (955×1 px, 215 KB)

Screen Shot 2015-06-21 at 8.16.46 PM.png (955×1 px, 215 KB)

Screen Shot 2015-06-21 at 8.19.58 PM.png (973×1 px, 183 KB)

Diff Detail

Repository

rP Phabricator

Branch

phrase4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6941
Build 6963: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32407.Jun 22 2015, 3:28 AM

epriestley retitled this revision from to Show when objects have a non-default policy.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6787: Clarify UI for Objects with a non-default Policy.

epriestley added a subscriber: chad.

Herald added a reviewer: chad. · View Herald TranscriptJun 22 2015, 3:28 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Colors are:

no color: default policy
green: weaker (less restrictive) policy
red: stronger (more restrictive) policy
orange: different policy which isn't categorically weaker or stronger (e.g., "memers of X" instead of "members of Y").

joshuaspence awarded a token.Jun 22 2015, 9:28 AM

joshuaspence added a subscriber: joshuaspence.

I wonder if the composed sentence I think you previously suggested might be worth exploring.

This Open task is viewable by All Users in the OPS space.

I hesitate to pursue that because it's routinely untrue. The sentence for Differential is:

This revision needs review, and is visible to all users in the X space who also have permission to view repository Y (which is visible to all members of P in the Z space), and also visible to the author, even if they can not see the repository, unless they can't see objects in the space.

In D13387#143228, @epriestley wrote:

This revision needs review, and is visible to all users in the X space who also have permission to view repository Y (which is visible to all members of P in the Z space), and also visible to the author, even if they can not see the repository, unless they can't see objects in the space.

Mordac The Prevented would love possible implications here... So with arrival of spaces is it possible to define policy combination using broad groups that would eneble for example only one person to perform any action at all (tghat is - view)?

Another sentence-y idea inline.

src/view/phui/PHUIHeaderView.php
362–368	Maybe we can do a tool tip with the text like "The current policy $curr_policy is more restrictive than the default of $default_policy."? Basically, not sure if the colors need more details or some quick explanation and the tooltip can maybe do both. Also, maybe there's some corner cases where the defaults are pretty aggressive and the tool tip helps with any user confusion there?

This revision is now accepted and ready to land.Jun 22 2015, 5:38 PM

epriestley added inline comments.Jun 22 2015, 5:43 PM