Page MenuHomePhabricator
Differential D13386

Support Spaces in Passphrase
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 2:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:05 PM
Unknown Object (File)
Fri, Apr 12, 3:25 AM
Unknown Object (File)
Fri, Apr 12, 3:25 AM
Unknown Object (File)
Fri, Apr 12, 3:19 AM
Unknown Object (File)
Fri, Apr 12, 2:58 AM
Unknown Object (File)
Thu, Apr 11, 7:15 AM
Unknown Object (File)
Tue, Apr 9, 11:16 PM
Unknown Object (File)
Tue, Apr 2, 4:26 PM
View All Files
Subscribers
epriestley
joshuaspence
Tokens
"Haypence" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T8493: Integrate Spaces into more applications
Commits
Restricted Diffusion Commit
rPe6b7f655ee80: Support Spaces in Passphrase
Summary

Ref T8493. This stuff mostly takes care of itself now.

Test Plan

Shifted stuff between spaces, verified transactions/headers showed up correctly. Queried by space.

Diff Detail

Repository
rP Phabricator
Branch
phrase3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6934
Build 6956: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32406.Jun 22 2015, 2:51 AM
epriestley retitled this revision from to Support Spaces in Passphrase.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8493: Integrate Spaces into more applications.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 22 2015, 2:51 AM
joshuaspence awarded a token.Jun 22 2015, 9:31 AM
joshuaspence added a subscriber: joshuaspence.
btrahan accepted this revision.Jun 22 2015, 5:28 PM
btrahan edited edge metadata.

Spaces integration came out very nice!

This revision is now accepted and ready to land.Jun 22 2015, 5:28 PM
Closed by commit rPe6b7f655ee80: Support Spaces in Passphrase (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2015, 6:29 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8376: Develop Spaces (v1).Jun 22 2015, 8:06 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
1 line
applications/
passphrase/
controller/
11 lines
storage/
16 lines

Diff 32406

View Options

resources/sql/autopatches/20150621.phrase.2.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
Phabricator · Built by Phacility