Page MenuHomePhabricator
Differential D13386

Support Spaces in Passphrase
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 2:51 AM.
Tags
None
Referenced Files
F15547843: D13386.id32417.diff
Sat, Apr 26, 8:24 PM
F15526674: D13386.id32406.diff
Mon, Apr 21, 10:13 PM
F15525346: D13386.id32406.diff
Mon, Apr 21, 1:45 PM
F15515642: D13386.id.diff
Fri, Apr 18, 12:12 PM
F15512053: D13386.diff
Thu, Apr 17, 7:32 AM
F15509646: D13386.id.diff
Wed, Apr 16, 2:59 PM
F15480958: D13386.id32406.diff
Tue, Apr 8, 5:33 PM
F15474561: D13386.id32417.diff
Apr 6 2025, 9:50 AM
View All Files
Subscribers
epriestley
joshuaspence
Tokens
"Haypence" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T8493: Integrate Spaces into more applications
Commits
Restricted Diffusion Commit
rPe6b7f655ee80: Support Spaces in Passphrase
Summary

Ref T8493. This stuff mostly takes care of itself now.

Test Plan

Shifted stuff between spaces, verified transactions/headers showed up correctly. Queried by space.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32406.Jun 22 2015, 2:51 AM
epriestley retitled this revision from to Support Spaces in Passphrase.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8493: Integrate Spaces into more applications.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 22 2015, 2:51 AM
joshuaspence awarded a token.Jun 22 2015, 9:31 AM
joshuaspence added a subscriber: joshuaspence.
btrahan accepted this revision.Jun 22 2015, 5:28 PM
btrahan edited edge metadata.

Spaces integration came out very nice!

This revision is now accepted and ready to land.Jun 22 2015, 5:28 PM
Closed by commit rPe6b7f655ee80: Support Spaces in Passphrase (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2015, 6:29 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8376: Develop Spaces (v1).Jun 22 2015, 8:06 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
1 line
applications/
passphrase/
controller/
11 lines
storage/
16 lines

Diff 32417

View Options

resources/sql/autopatches/20150621.phrase.2.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
Phabricator · Built by Phacility