Move Passphrase to SearchField
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 2:27 AM.

Details

Reviewers

btrahan

Commits

Summary

Prepares for bringing spaces and a new object policy here.

Test Plan

Used all search controls dozens of times.

Repository

rP Phabricator

Branch

phrase1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6932
Build 6954: [Placeholder Plan] Wait for 30 Seconds

epriestley retitled this revision from to Move Passphrase to SearchField.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/passphrase/query/PassphraseCredentialQuery.php
143	just double checking intentional

This revision is now accepted and ready to land.Jun 22 2015, 5:19 PM

src/applications/passphrase/query/PassphraseCredentialQuery.php
143	Yeah, just smoothing out searching for "Twitter" to match "twitter", which doesn't work without this. This isn't really ideal but is a quick hack to improve behavior without any real negative effects AFAIK.