Paths

Table of Contentst

Differential D13374

Move some PhabricatorSearchField subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jun 21 2015, 6:38 AM.

Tags

None

Referenced Files

	F13084148: D13374.diff
	Wed, Apr 24, 10:49 PM

	Unknown Object (File)
	Mar 25 2024, 1:53 PM

	Unknown Object (File)
	Mar 20 2024, 3:47 PM

	Unknown Object (File)
	Mar 20 2024, 2:35 AM

	Unknown Object (File)
	Mar 4 2024, 1:38 PM

	Unknown Object (File)
	Mar 4 2024, 1:35 PM

	Unknown Object (File)
	Feb 14 2024, 5:32 PM

	Unknown Object (File)
	Feb 13 2024, 11:55 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPacb1eb81ccf4: Move some PhabricatorSearchField subclasses

Summary

Move some PhabricatorSearchField subclasses to be adjacent to the application to which they belong. This seems generally better to me than lumping them all together in the src/applications/search/field/ directory. I was also wondering if it makes sense to rename these subclasses as PhabricatorXSearchField rather than PhabricatorSearchXField (as per T5655), but wasn't really sure if these objects are meant to be search-fields, or just fields belonging to the Search application.

Test Plan

N/A.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32378.Jun 21 2015, 6:38 AM

joshuaspence retitled this revision from to Move some PhabricatorSearchField subclasses.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 21 2015, 6:38 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Yeah, feel free to rename them. I didn't really plan this one as carefully as I probably should have.

This revision is now accepted and ready to land.Jun 21 2015, 11:20 AM

Rename classes

Closed by commit rPacb1eb81ccf4: Move some PhabricatorSearchField subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 6 2015, 12:54 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13575: Fix a broken class reference.Jul 7 2015, 12:33 PM

joshuaspence mentioned this in rP12a088d8b7dc: Fix a broken class reference.Jul 7 2015, 12:53 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

18 lines

applications/

files/

query/

PhabricatorFileSearchEngine.php

2 lines

macro/

query/

PhabricatorMacroSearchEngine.php

2 lines

maniphest/

query/

ManiphestTaskSearchEngine.php

4 lines

metamta/

query/

PhabricatorMetaMTAMailSearchEngine.php

4 lines

	owners/	searchfield/
	search/	field/

	PhabricatorOwnersSearchField.php
	PhabricatorSearchOwnersField.php

2 lines

paste/

query/

PhabricatorPasteSearchEngine.php

2 lines

	people/	search/
	search/	field/

	PhabricatorUserSearchField.php
	PhabricatorSearchUsersField.php

2 lines

people/

search/

PhabricatorUserSearchIndexer.php

	searchfield/
	search/

PhabricatorUserSearchIndexer.php

pholio/

query/

PholioMockSearchEngine.php

2 lines

project/

query/

PhabricatorProjectSearchEngine.php

2 lines

	project/	searchfield/
	search/	field/

	PhabricatorProjectSearchField.php
	PhabricatorSearchProjectsField.php

2 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

4 lines

field/

PhabricatorSearchOwnersField.php

PhabricatorSearchProjectsField.php

PhabricatorSearchSpacesField.php

PhabricatorSearchUsersField.php

	spaces/	searchfield/
	search/	field/

	PhabricatorSpacesSearchField.php
	PhabricatorSearchSpacesField.php

2 lines

infrastructure/

daemon/

workers/

query/

PhabricatorWorkerBulkJobSearchEngine.php

2 lines

Diff 32761

src/__phutil_library_map__.php

Loading...

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...

src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php

Loading...

src/applications/owners/searchfield/PhabricatorOwnersSearchField.php

Loading...

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...

src/applications/people/search/PhabricatorUserSearchField.php

Loading...

src/applications/people/search/PhabricatorUserSearchIndexer.php

Loading...

src/applications/people/searchfield/PhabricatorUserSearchIndexer.php

Loading...

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...

src/applications/project/searchfield/PhabricatorProjectSearchField.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...

src/applications/search/field/PhabricatorSearchOwnersField.php

Loading...

src/applications/search/field/PhabricatorSearchProjectsField.php

Loading...

src/applications/search/field/PhabricatorSearchSpacesField.php

Loading...

src/applications/search/field/PhabricatorSearchUsersField.php

Loading...

src/applications/spaces/searchfield/PhabricatorSpacesSearchField.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php

Loading...