Page MenuHomePhabricator
Differential D13372

Minor tidying of PhutilSymbolLoader
ClosedPublic
Actions

Authored by joshuaspence on Jun 21 2015, 2:57 AM.
Tags
None
Referenced Files
F13098066: D13372.id.diff
Fri, Apr 26, 4:02 AM
F13097141: D13372.id32376.diff
Thu, Apr 25, 9:19 PM
Unknown Object (File)
Thu, Apr 25, 7:12 AM
Unknown Object (File)
Thu, Apr 25, 2:15 AM
Unknown Object (File)
Thu, Apr 25, 12:22 AM
Unknown Object (File)
Thu, Apr 11, 9:40 AM
Unknown Object (File)
Mon, Apr 8, 11:08 PM
Unknown Object (File)
Sun, Apr 7, 8:40 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU6fedd82a29a0: Minor tidying of PhutilSymbolLoader
Summary

Minor improvements to the documentation of PhutilSymbolLoader.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32376.Jun 21 2015, 2:57 AM
joshuaspence retitled this revision from to Minor tidying of PhutilSymbolLoader.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 21 2015, 2:57 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 21 2015, 10:55 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2015, 10:55 AM
joshuaspence added inline comments.Jun 21 2015, 9:59 PM
src/symbols/PhutilSymbolLoader.php
35–37

As a side note, we could potentially formalize this with an @no-phutil annotation.

Closed by commit rPHU6fedd82a29a0: Minor tidying of PhutilSymbolLoader (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 21 2015, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
symbols/
59 lines

Diff 32398

View Options

src/symbols/PhutilSymbolLoader.php

Loading...
Phabricator · Built by Phacility