Hide repository from atom view if it hasn't been set
ClosedPublic
Actions

Authored by joshuaspence on Jun 21 2015, 12:04 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8626: Diviner book is linked to an unknown object

Commits

Restricted Diffusion Commit
rPf9e838024c71: Hide repository from atom view if it hasn't been set

Summary

Fixes T8626. I guess that $this->getViewer()->renderHandle(null) renders as "Unknown Object", which is somewhat odd to me.

Test Plan

Viewed an atom from a book without a repository linked to it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32368.Jun 21 2015, 12:04 AM

joshuaspence retitled this revision from to Hide repository from atom view if it hasn't been set.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8626: Diviner book is linked to an unknown object.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 21 2015, 12:04 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 21 2015, 12:16 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 21 2015, 12:16 AM

Closed by commit rPf9e838024c71: Hide repository from atom view if it hasn't been set (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 21 2015, 1:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

controller/

DivinerAtomController.php

4 lines

Diff 32374

View Options

src/applications/diviner/controller/DivinerAtomController.php

Hide repository from atom view if it hasn't been setClosedPublicActions