Page MenuHomePhabricator

Provide general documentation on how to use perfomance tools
ClosedPublic

Authored by epriestley on Jun 19 2015, 7:10 PM.
Tags
None
Referenced Files
F13209986: D13359.diff
Fri, May 17, 3:12 AM
F13203322: D13359.diff
Tue, May 14, 11:39 PM
F13185645: D13359.diff
Sat, May 11, 3:06 AM
Unknown Object (File)
Tue, May 7, 5:34 AM
Unknown Object (File)
Fri, May 3, 3:18 AM
Unknown Object (File)
Thu, May 2, 11:04 AM
Unknown Object (File)
Thu, May 2, 11:04 AM
Unknown Object (File)
Thu, May 2, 11:04 AM

Details

Summary

Ref T8617. Provide general documentation with tools for debugging hangs and slow pages. Update DarkConsole docs and discuss how to use Services and XHProf. Explain what Multimeter is for and how to use it. Update XHProf docs and provide some usage hints.

Test Plan

Read documentation.

Diff Detail

Repository
rP Phabricator
Branch
perfdocs
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6879
Build 6901: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Provide general documentation on how to use perfomance tools.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Oh, I'll link up the multimeter doc in the app too.

btrahan edited edge metadata.
btrahan added inline comments.
src/docs/user/field/performance.diviner
63–64

maybe add a sentence or make it one super sentence with the "if so, consider other ways to solve the problem".

This revision is now accepted and ready to land.Jun 19 2015, 9:11 PM
joshuaspence added a reviewer: joshuaspence.
joshuaspence added a subscriber: joshuaspence.
joshuaspence added inline comments.
src/docs/user/field/darkconsole.diviner
16–27

Should this maybe just do a big WARNING: block so that it is styled as such?

17

I found it distracting that the length of the = chain isn't the same as the title text.

33–40

Having single sentence paragraphs looks slightly odd to me.

160–161

I think these should start with a capital letter

src/docs/user/field/performance.diviner
133

Maybe wrap SIGHUP in `

epriestley edited edge metadata.
  • Align ===.
  • Take most of the tweaks.
This revision was automatically updated to reflect the committed changes.