Page MenuHomePhabricator
Differential D13327

Use PhutilInvalidStateException
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2015, 10:26 AM.
Tags
None
Referenced Files
F18806212: D13327.diff
Sat, Oct 18, 6:28 PM
F18659685: D13327.diff
Sep 23 2025, 2:49 PM
F18226399: D13327.id.diff
Aug 20 2025, 3:59 AM
F18216796: D13327.id32245.diff
Aug 19 2025, 7:59 AM
F18205039: D13327.diff
Aug 18 2025, 2:26 PM
F18089370: D13327.id32245.diff
Aug 6 2025, 11:20 AM
F18088107: D13327.id.diff
Aug 6 2025, 6:54 AM
F18037158: D13327.id32245.diff
Aug 3 2025, 2:28 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP4761cb8d7390: Use PhutilInvalidStateException
Summary

Use PhutilInvalidStateException where appropriate.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32245.Jun 17 2015, 10:26 AM
joshuaspence retitled this revision from to Use PhutilInvalidStateException.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2015, 10:26 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 17 2015, 12:02 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/aphront/AphrontController.php
86

Could probably just be MethodNotImplementedException, I think the specificity of this message is overkill.

This revision is now accepted and ready to land.Jun 17 2015, 12:02 PM
Closed by commit rP4761cb8d7390: Use PhutilInvalidStateException (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 17 2015, 9:10 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence marked an inline comment as done.

Revision Contents
Changeset List

PathSize
src/
aphront/
16 lines
applications/
auth/
engine/
2 lines
conpherence/
view/
2 lines
dashboard/
engine/
4 lines
infrastructure/
markup/
5 lines
view/
form/
control/
4 lines
7 lines
layout/
4 lines
2 lines
phui/
2 lines

Diff 32263

View Options

src/aphront/AphrontController.php

Loading...
View Options

src/applications/auth/engine/PhabricatorAuthInviteEngine.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/view/form/control/AphrontFormPolicyControl.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

src/view/layout/PhabricatorActionListView.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
Phabricator · Built by Phacility