Differential D13324

Cache viewer spaces
ClosedPublic
Actions

Authored by epriestley on Jun 17 2015, 2:45 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T8575: Reap easy performance improvements

Commits

Restricted Diffusion Commit
rP984976ce2029: Cache viewer spaces

Summary

Ref T8575. Although we cache spaces as a whole, we don't cache viewer spaces. This can still do a lot of work if they have complex policies.

Instead, cache them in the request cache.

Test Plan

Saw this account for 37% of a page in produciton (303ms on on 835ms).

Diff Detail

Repository

rP Phabricator

Branch

perf3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6823
Build 6845: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32242.Jun 17 2015, 2:45 AM

epriestley retitled this revision from to Cache viewer spaces.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8575: Reap easy performance improvements.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 17 2015, 2:45 AM

btrahan accepted this revision.Jun 17 2015, 5:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 17 2015, 5:33 PM

Closed by commit rP984976ce2029: Cache viewer spaces (authored by epriestley, committed by epriestley). · Explain WhyJun 17 2015, 5:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

spaces/

query/

PhabricatorSpacesNamespaceQuery.php

27 lines

Diff 32242

View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

Cache viewer spacesClosedPublicActions