Page MenuHomePhabricator

Cache viewer spaces
ClosedPublic

Authored by epriestley on Jun 17 2015, 2:45 AM.
Tags
None
Referenced Files
F12842076: D13324.diff
Thu, Mar 28, 9:44 PM
F12814895: D13324.id32242.diff
Thu, Mar 28, 2:24 AM
Unknown Object (File)
Thu, Mar 21, 7:51 AM
Unknown Object (File)
Thu, Mar 21, 4:22 AM
Unknown Object (File)
Feb 4 2024, 9:27 PM
Unknown Object (File)
Jan 28 2024, 2:03 AM
Unknown Object (File)
Jan 16 2024, 5:47 PM
Unknown Object (File)
Jan 12 2024, 5:49 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T8575: Reap easy performance improvements
Commits
Restricted Diffusion Commit
rP984976ce2029: Cache viewer spaces
Summary

Ref T8575. Although we cache spaces as a whole, we don't cache viewer spaces. This can still do a lot of work if they have complex policies.

Instead, cache them in the request cache.

Test Plan

Saw this account for 37% of a page in produciton (303ms on on 835ms).

Diff Detail

Repository
rP Phabricator
Branch
perf3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6823
Build 6845: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Cache viewer spaces.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2015, 5:33 PM
This revision was automatically updated to reflect the committed changes.