Paths

Table of Contentst

Differential D13304

Set icons for Diviner PHID types
ClosedPublic
Actions

Authored by joshuaspence on Jun 16 2015, 12:41 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4558: Make Diviner useful for third-parties

Commits

Restricted Diffusion Commit
rP751162d363e6: Set icons for Diviner PHID types

Summary

Ref T4558. Give DivinerAtomPHIDType and DivinerBookPHIDType a font icon.

Test Plan

Saw icons in global search.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32192.Jun 16 2015, 12:41 PM

joshuaspence retitled this revision from to Set icons for Diviner PHID types.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T4558: Make Diviner useful for third-parties.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2015, 12:41 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 16 2015, 1:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2015, 1:53 PM

Closed by commit rP751162d363e6: Set icons for Diviner PHID types (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 16 2015, 9:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

phid/

DivinerAtomPHIDType.php

4 lines

DivinerBookPHIDType.php

4 lines

Diff 32220

View Options

src/applications/diviner/phid/DivinerAtomPHIDType.php