Page MenuHomePhabricator

Remove `break` from hunk migration
ClosedPublic

Authored by joshuaspence on Jun 14 2015, 10:00 PM.
Tags
None
Referenced Files
F18240668: D13288.id32129.diff
Thu, Aug 21, 1:14 AM
F18086525: D13288.id32131.diff
Tue, Aug 5, 10:23 PM
F18051380: D13288.diff
Sun, Aug 3, 11:09 PM
Unknown Object (File)
Jun 29 2025, 9:54 AM
Unknown Object (File)
Jun 28 2025, 10:01 PM
Unknown Object (File)
May 30 2025, 10:06 PM
Unknown Object (File)
May 29 2025, 10:34 AM
Unknown Object (File)
May 28 2025, 11:20 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP175799fab99b: Remove `break` from hunk migration
Summary

This break statement causes ./bin/hunks migrate to only migrate one-hunk-at-a-time, which is unnecessary and slightly misleading. Instead, allow the script to migrate all legacy hunks to modern storage. In particular, this means that we can recommend that installs run this command sometime before D13222 is landed.

Test Plan

It's a pain to setup the data necessary to test this, but this is identical to the change that I made on our production install when I migrated our hunk storage.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Remove `break` from hunk migration.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2015, 10:04 PM
This revision was automatically updated to reflect the committed changes.