Paths

Table of Contentst

Differential D13281

Extend from Phobject
ClosedPublic
Actions

Authored by joshuaspence on Jun 14 2015, 12:52 PM.

Tags

None

Referenced Files

	F15422037: D13281.id32103.diff
	Sat, Mar 22, 4:56 AM

	F15420591: D13281.id.diff
	Fri, Mar 21, 3:14 PM

	F15417948: D13281.diff
	Thu, Mar 20, 7:40 PM

	F15413435: D13281.id.diff
	Wed, Mar 19, 6:41 PM

	F15385824: D13281.id.diff
	Fri, Mar 14, 11:29 PM

	Unknown Object (File)
	Feb 16 2025, 10:16 PM

	Unknown Object (File)
	Feb 10 2025, 10:30 PM

	Unknown Object (File)
	Feb 8 2025, 10:17 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC956bfa701c36: Extend from Phobject

Summary

All base classes should extend from Phobject or some other classes. See D13275 for some explanation.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6744
Build 6766: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	10 ms	PhpunitTestEngineTestCase::testSearchLocations
	0 ms	PhutilUnitTestEngineTestCase::testGetTestPaths
	1 ms	ArcanistBaseCommitParserTestCase::testBasics
	0 ms	ArcanistBaseCommitParserTestCase::testHalt
	0 ms	ArcanistBaseCommitParserTestCase::testJump
		View Full Test Results (2 Failed · 86 Passed · 11 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 32103.Jun 14 2015, 12:52 PM

joshuaspence retitled this revision from to Extend from Phobject.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 14 2015, 12:52 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 14 2015, 1:40 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 14 2015, 1:40 PM

joshuaspence updated this object.Jun 15 2015, 5:45 AM

joshuaspence edited edge metadata.

Closed by commit rARC956bfa701c36: Extend from Phobject (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 5:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

35 lines

configuration/

ArcanistConfiguration.php

2 lines

ArcanistConfigurationManager.php

2 lines

ArcanistSettings.php

2 lines

difference/

ArcanistDiffUtils.php

2 lines

differential/

ArcanistDifferentialCommitMessage.php

2 lines

constants/

ArcanistDifferentialRevisionHash.php

2 lines

ArcanistDifferentialRevisionStatus.php

2 lines

hgdaemon/

ArcanistHgProxyClient.php

2 lines

ArcanistHgProxyServer.php

2 lines

lint/

ArcanistLintMessage.php

2 lines

ArcanistLintPatcher.php

2 lines

ArcanistLintResult.php

2 lines

ArcanistLintSeverity.php

2 lines

engine/

ArcanistLintEngine.php

2 lines

linter/

ArcanistLinter.php

2 lines

xhpast/

ArcanistXHPASTLintNamingHook.php

2 lines

ArcanistXHPASTLintSwitchHook.php

2 lines

ArcanistXHPASTLinterRule.php

2 lines

renderer/

ArcanistLintRenderer.php

2 lines

parser/

ArcanistBaseCommitParser.php

2 lines

ArcanistBundle.php

2 lines

ArcanistCommentRemover.php

2 lines

ArcanistDiffParser.php

2 lines

diff/

ArcanistDiffChange.php

2 lines

ArcanistDiffChangeType.php

2 lines

ArcanistDiffHunk.php

2 lines

repository/

api/

ArcanistRepositoryAPI.php

2 lines

parser/

ArcanistMercurialParser.php

2 lines

unit/

ArcanistUnitTestResult.php

2 lines

engine/

ArcanistUnitTestEngine.php

3 lines

phutil/

PhutilTestCase.php

2 lines

parser/

ArcanistTestResultParser.php

2 lines

ArcanistXUnitTestResultParser.php

2 lines

renderer/

ArcanistUnitRenderer.php

2 lines

workingcopyidentity/

ArcanistWorkingCopyIdentity.php

2 lines

Diff 32103

src/__phutil_library_map__.php

Loading...

src/configuration/ArcanistConfiguration.php

Loading...

src/configuration/ArcanistConfigurationManager.php

Loading...

src/configuration/ArcanistSettings.php

Loading...

src/difference/ArcanistDiffUtils.php

Loading...

src/differential/ArcanistDifferentialCommitMessage.php

Loading...

src/differential/constants/ArcanistDifferentialRevisionHash.php

Loading...

src/differential/constants/ArcanistDifferentialRevisionStatus.php

Loading...

src/hgdaemon/ArcanistHgProxyClient.php

Loading...

src/hgdaemon/ArcanistHgProxyServer.php

Loading...

src/lint/ArcanistLintMessage.php

Loading...

src/lint/ArcanistLintPatcher.php

Loading...

src/lint/ArcanistLintResult.php

Loading...

src/lint/ArcanistLintSeverity.php

Loading...

src/lint/engine/ArcanistLintEngine.php

Loading...

src/lint/linter/ArcanistLinter.php

Loading...

src/lint/linter/xhpast/ArcanistXHPASTLintNamingHook.php

Loading...

src/lint/linter/xhpast/ArcanistXHPASTLintSwitchHook.php

Loading...

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...

src/lint/renderer/ArcanistLintRenderer.php

Loading...

src/parser/ArcanistBaseCommitParser.php

Loading...

src/parser/ArcanistBundle.php

Loading...

src/parser/ArcanistCommentRemover.php

Loading...

src/parser/ArcanistDiffParser.php

Loading...

src/parser/diff/ArcanistDiffChange.php

Loading...

src/parser/diff/ArcanistDiffChangeType.php

Loading...

src/parser/diff/ArcanistDiffHunk.php

Loading...

src/repository/api/ArcanistRepositoryAPI.php

Loading...

src/repository/parser/ArcanistMercurialParser.php

Loading...

src/unit/ArcanistUnitTestResult.php

Loading...

src/unit/engine/ArcanistUnitTestEngine.php

Loading...

src/unit/engine/phutil/PhutilTestCase.php

Loading...

src/unit/parser/ArcanistTestResultParser.php

Loading...

src/unit/parser/ArcanistXUnitTestResultParser.php

Loading...

src/unit/renderer/ArcanistUnitRenderer.php

Loading...

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

Loading...