Page MenuHomePhabricator

Add some tests for subclasses
ClosedPublic

Authored by joshuaspence on Jun 13 2015, 8:46 AM.

Details

Summary

Add some tests to ensure that ArcanistXHPASTLinterRule subclasses are properly implemented. This should catch issues such as two linter rules having the same ID value. See D13272 for a similar change.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 6725
Build 6747: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

Excuse: unrelated
TimeTest
1,607 msArcanistJSHintLinterTestCase::testLinter
680 msArcanistJscsLinterTestCase::testLinter
28 msArcanistPuppetLintLinterTestCase::testLinter
6 msArcanistPuppetLintLinterTestCase::testVersion
21 msArcanistRuboCopLinterTestCase::testLinter
View Full Test Results (6 Failed · 46 Passed · 3 Skipped)

Event Timeline

joshuaspence retitled this revision from to Add some tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2015, 3:24 PM
joshuaspence retitled this revision from Add some tests to Add some tests for subclasses.Jun 15 2015, 8:04 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.