Page MenuHomePhabricator
Differential D13274

Add some tests for subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jun 13 2015, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:04 AM
Unknown Object (File)
Sat, Apr 6, 4:13 AM
Unknown Object (File)
Tue, Apr 2, 9:47 AM
Unknown Object (File)
Tue, Apr 2, 9:03 AM
Unknown Object (File)
Thu, Mar 28, 10:21 PM
Unknown Object (File)
Thu, Mar 28, 3:06 PM
Unknown Object (File)
Feb 24 2024, 1:29 AM
Unknown Object (File)
Feb 15 2024, 10:50 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCfe4856277c6c: Add some tests for subclasses
Summary

Add some tests to ensure that ArcanistXHPASTLinterRule subclasses are properly implemented. This should catch issues such as two linter rules having the same ID value. See D13272 for a similar change.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32073.Jun 13 2015, 8:46 AM
joshuaspence retitled this revision from to Add some tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2015, 8:46 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 13 2015, 3:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2015, 3:24 PM
joshuaspence retitled this revision from Add some tests to Add some tests for subclasses.Jun 15 2015, 8:04 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.
Closed by commit rARCfe4856277c6c: Add some tests for subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 10:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32158

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLinterRuleTestCase.php

Loading...
Phabricator · Built by Phacility