Page MenuHomePhabricator

Add some tests for subclasses
ClosedPublic

Authored by joshuaspence on Jun 13 2015, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 5:43 PM
Unknown Object (File)
Sat, Nov 2, 1:54 AM
Unknown Object (File)
Sat, Nov 2, 1:54 AM
Unknown Object (File)
Sat, Nov 2, 1:54 AM
Unknown Object (File)
Thu, Oct 31, 10:52 PM
Unknown Object (File)
Oct 15 2024, 12:09 PM
Unknown Object (File)
Oct 15 2024, 12:05 PM
Unknown Object (File)
Oct 15 2024, 12:04 PM
Subscribers

Details

Summary

Add some tests to ensure that ArcanistXHPASTLinterRule subclasses are properly implemented. This should catch issues such as two linter rules having the same ID value. See D13272 for a similar change.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add some tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2015, 3:24 PM
joshuaspence retitled this revision from Add some tests to Add some tests for subclasses.Jun 15 2015, 8:04 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.