Page MenuHomePhabricator
Differential D13250

Fix feed query cursor-based pagination on 32-bit systems
ClosedPublic
Actions

Authored by epriestley on Jun 11 2015, 4:45 PM.
Tags
None
Referenced Files
F15535801: D13250.diff
Thu, Apr 24, 6:48 AM
F15523221: D13250.diff
Sun, Apr 20, 11:55 PM
F15492880: D13250.id32024.diff
Sat, Apr 12, 7:17 PM
F15485852: D13250.id32029.diff
Thu, Apr 10, 3:00 AM
F15485841: D13250.id32024.diff
Thu, Apr 10, 2:56 AM
F15485840: D13250.id.diff
Thu, Apr 10, 2:56 AM
F15450365: D13250.id32029.diff
Fri, Mar 28, 3:17 PM
F15448136: D13250.id.diff
Fri, Mar 28, 3:18 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8503: Feed query may fail to progress while paging on 32-bit systems
Commits
Restricted Diffusion Commit
rPc71873ed7b31: Fix feed query cursor-based pagination on 32-bit systems
Summary

Fixes T8503. On 32-bit systems, these 64-bit integers will be mangled by the '%d' conversion implied by the 'int' type.

Test Plan

Somewhat guessing here since I don't have a 32-bit system handy, but this strongly echoes similar issues in the past. Feed works fine locally. Looked at the generated queries.

Diff Detail

Repository
rP Phabricator
Branch
feed1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6689
Build 6711: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32024.Jun 11 2015, 4:45 PM
epriestley retitled this revision from to Fix feed query cursor-based pagination on 32-bit systems.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8503: Feed query may fail to progress while paging on 32-bit systems.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2015, 4:45 PM
btrahan accepted this revision.Jun 11 2015, 5:22 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2015, 5:22 PM
Closed by commit rPc71873ed7b31: Fix feed query cursor-based pagination on 32-bit systems (authored by epriestley, committed by epriestley). · Explain WhyJun 11 2015, 5:23 PM
This revision was automatically updated to reflect the committed changes.
staticshock mentioned this in T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.Jun 11 2015, 7:35 PM
epriestley mentioned this in T8376: Develop Spaces (v1).Jun 12 2015, 7:12 PM

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
query/
2 lines

Diff 32024

View Options

src/applications/feed/query/PhabricatorFeedQuery.php

Loading...
Phabricator · Built by Phacility