Differential D13250

Fix feed query cursor-based pagination on 32-bit systems
ClosedPublic
Actions

Authored by epriestley on Jun 11 2015, 4:45 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8503: Feed query may fail to progress while paging on 32-bit systems

Commits

Restricted Diffusion Commit
rPc71873ed7b31: Fix feed query cursor-based pagination on 32-bit systems

Summary

Fixes T8503. On 32-bit systems, these 64-bit integers will be mangled by the '%d' conversion implied by the 'int' type.

Test Plan

Somewhat guessing here since I don't have a 32-bit system handy, but this strongly echoes similar issues in the past. Feed works fine locally. Looked at the generated queries.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32024.Jun 11 2015, 4:45 PM

epriestley retitled this revision from to Fix feed query cursor-based pagination on 32-bit systems.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8503: Feed query may fail to progress while paging on 32-bit systems.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2015, 4:45 PM

btrahan accepted this revision.Jun 11 2015, 5:22 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 11 2015, 5:22 PM

Closed by commit rPc71873ed7b31: Fix feed query cursor-based pagination on 32-bit systems (authored by epriestley, committed by epriestley). · Explain WhyJun 11 2015, 5:23 PM

This revision was automatically updated to reflect the committed changes.

staticshock mentioned this in T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.Jun 11 2015, 7:35 PM

epriestley mentioned this in T8376: Develop Spaces (v1).Jun 12 2015, 7:12 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

query/

PhabricatorFeedQuery.php

2 lines

Diff 32029

View Options

src/applications/feed/query/PhabricatorFeedQuery.php

Fix feed query cursor-based pagination on 32-bit systemsClosedPublicActions