Page MenuHomePhabricator

Allow Aphlict admin server to be specified
Needs ReviewPublic

Authored by joshuaspence on Jun 4 2015, 5:30 AM.
Tags
None
Referenced Files
F14037960: D13148.diff
Sun, Nov 10, 8:25 PM
F14030877: D13148.id31785.diff
Sat, Nov 9, 7:59 AM
F13978735: D13148.diff
Sat, Oct 19, 12:43 AM
F13961279: D13148.id.diff
Tue, Oct 15, 4:09 AM
F13960753: D13148.diff
Tue, Oct 15, 1:12 AM
F13960747: D13148.id.diff
Tue, Oct 15, 1:09 AM
F13960744: D13148.id31780.diff
Tue, Oct 15, 1:08 AM
Unknown Object (File)
Sep 21 2024, 3:05 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Allow flags to be passed to ./bin/aphlict to specify the hostname and port for the admin server. On our install, notification.server-uri is set to notify.phabricator.mydomain.com and, as such, the NodeJS server is started with --admin-host=notify.phabricator.mydomain.com instead of the desired --admin-host=0.0.0.0.

This is essentially another take on D11359.

Test Plan

Ran ./bin/aphlict debug with a bunch of different arguments.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6536
Build 6558: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Allow Aphlict admin server to be specified.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.