Page MenuHomePhabricator
Differential D13126

Improve test discovery with PhutilUnitTestEngine
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 6:26 PM
Unknown Object (File)
Sat, Nov 9, 9:11 AM
Unknown Object (File)
Sat, Nov 9, 9:11 AM
Unknown Object (File)
Sat, Nov 9, 9:10 AM
Unknown Object (File)
Tue, Nov 5, 9:39 PM
Unknown Object (File)
Oct 19 2024, 7:17 PM
Unknown Object (File)
Oct 16 2024, 5:12 PM
Unknown Object (File)
Oct 15 2024, 8:15 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8042: PhutilUnitTestEngine can't execute a single test path
Commits
rARC8c589f1f759f: Improve test discovery with PhutilUnitTestEngine
Summary

Ref T8042. Tests were not being discovered in two different scenarios:

  1. Files modified at the same level as the library root directory.
  2. "Normal" directories like src/unit/engine.

This regression was caused by D12689.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31690.Jun 2 2015, 9:15 PM
joshuaspence retitled this revision from to Improve test discovery with PhutilUnitTestEngine.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 9:15 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Jun 2 2015, 9:16 PM
joshuaspence edited edge metadata.
joshuaspence added a task: T8042: PhutilUnitTestEngine can't execute a single test path.
epriestley accepted this revision.Jun 3 2015, 2:05 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2015, 2:05 AM
Closed by commit rARC8c589f1f759f: Improve test discovery with PhutilUnitTestEngine (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 3 2015, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
unit/
engine/
12 lines
__tests__/
33 lines

Diff 31716

View Options

src/unit/engine/PhutilUnitTestEngine.php

Loading...
View Options

src/unit/engine/__tests__/PhutilUnitTestEngineTestCase.php

Loading...
Phabricator · Built by Phacility