Page MenuHomePhabricator
Differential D13126

Improve test discovery with PhutilUnitTestEngine
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 9:15 PM.
Tags
None
Referenced Files
F18762300: D13126.id31716.diff
Mon, Oct 6, 6:23 PM
F18755979: D13126.id31690.diff
Sun, Oct 5, 8:27 AM
F18645591: D13126.diff
Sep 19 2025, 8:11 AM
F18523873: D13126.diff
Sep 6 2025, 11:24 AM
F18088395: D13126.id31716.diff
Aug 6 2025, 7:44 AM
F18041202: D13126.id31690.diff
Aug 3 2025, 4:26 AM
F17956439: D13126.id.diff
Aug 1 2025, 5:32 AM
F17921907: D13126.diff
Jul 30 2025, 6:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8042: PhutilUnitTestEngine can't execute a single test path
Commits
rARC8c589f1f759f: Improve test discovery with PhutilUnitTestEngine
Summary

Ref T8042. Tests were not being discovered in two different scenarios:

  1. Files modified at the same level as the library root directory.
  2. "Normal" directories like src/unit/engine.

This regression was caused by D12689.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6477
Build 6499: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31690.Jun 2 2015, 9:15 PM
joshuaspence retitled this revision from to Improve test discovery with PhutilUnitTestEngine.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 9:15 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Jun 2 2015, 9:16 PM
joshuaspence edited edge metadata.
joshuaspence added a task: T8042: PhutilUnitTestEngine can't execute a single test path.
epriestley accepted this revision.Jun 3 2015, 2:05 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2015, 2:05 AM
Closed by commit rARC8c589f1f759f: Improve test discovery with PhutilUnitTestEngine (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 3 2015, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
unit/
engine/
12 lines
__tests__/
33 lines

Diff 31690

View Options

src/unit/engine/PhutilUnitTestEngine.php

Loading...
View Options

src/unit/engine/__tests__/PhutilUnitTestEngineTestCase.php

Loading...
Phabricator · Built by Phacility