[Redesign] PHUIPagerView
ClosedPublic
Actions

Authored by chad on Jun 1 2015, 4:32 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8342: Design a new PHUIPagerView, allow setting to objects
T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rPe4788df9a505: [Redesign] PHUIPagerView

Summary

Ref T8099, Moves AphrontPagerView to PHUIPagerView, converts to standard PHUIButtons and adds some additional features for icon placement on buttons.

Test Plan

Tested Advanced Search and Searching files in Diffusion. Works as expected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 31596.Jun 1 2015, 4:32 AM

chad retitled this revision from to [Redesign] PHUIPagerView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJun 1 2015, 4:32 AM

chad added a task: T8342: Design a new PHUIPagerView, allow setting to objects.Jun 2 2015, 2:51 AM

epriestley accepted this revision.Jun 2 2015, 11:56 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 2 2015, 11:56 AM

Closed by commit rPe4788df9a505: [Redesign] PHUIPagerView (authored by chad, committed by chad). · Explain WhyJun 2 2015, 9:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

packages.php

2 lines

src/

__phutil_library_map__.php

4 lines

applications/

diffusion/

controller/

DiffusionBranchTableController.php

2 lines

DiffusionBrowseSearchController.php

2 lines

DiffusionHistoryController.php

2 lines

DiffusionLintDetailsController.php

2 lines

DiffusionTagListController.php

2 lines

drydock/

controller/

DrydockBlueprintViewController.php

2 lines

DrydockLeaseViewController.php

2 lines

DrydockResourceViewController.php

2 lines

phame/

controller/

blog/

PhameBlogListController.php

2 lines

phriction/

controller/

PhrictionHistoryController.php

2 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

2 lines

tokens/

controller/

PhabricatorTokenLeaderController.php

2 lines

uiexample/

examples/

PhabricatorPagerUIExample.php

10 lines

xhprof/

controller/

PhabricatorXHProfSampleListController.php

2 lines

infrastructure/

query/

PhabricatorOffsetPagedQuery.php

2 lines

view/

control/

AphrontCursorPagerView.php

49 lines

AphrontPagerView.php

phui/

PHUIButtonView.php

14 lines

	phui/
	control/

	PHUIPagerView.php
	AphrontPagerView.php

24 lines

webroot/

rsrc/

css/

aphront/

pager-view.css

phui/

phui-button.css

9 lines

phui-pager.css

8 lines

Diff 31693

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

View Options

src/applications/diffusion/controller/DiffusionBrowseSearchController.php

View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

View Options

src/applications/diffusion/controller/DiffusionLintDetailsController.php

View Options

src/applications/diffusion/controller/DiffusionTagListController.php

View Options

src/applications/drydock/controller/DrydockBlueprintViewController.php

View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

View Options

src/applications/drydock/controller/DrydockResourceViewController.php

View Options

src/applications/phame/controller/blog/PhameBlogListController.php

View Options

src/applications/phriction/controller/PhrictionHistoryController.php

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

View Options

src/applications/tokens/controller/PhabricatorTokenLeaderController.php

View Options

src/applications/uiexample/examples/PhabricatorPagerUIExample.php

View Options

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php

View Options

src/infrastructure/query/PhabricatorOffsetPagedQuery.php

View Options

src/view/control/AphrontCursorPagerView.php

View Options

src/view/control/AphrontPagerView.php

View Options

src/view/phui/PHUIButtonView.php

View Options

src/view/phui/PHUIPagerView.php

View Options

webroot/rsrc/css/aphront/pager-view.css

View Options

webroot/rsrc/css/phui/phui-button.css

View Options

webroot/rsrc/css/phui/phui-pager.css

[Redesign] PHUIPagerViewClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31693

resources/celerity/map.php

resources/celerity/packages.php

src/__phutil_library_map__.php

src/applications/diffusion/controller/DiffusionBranchTableController.php

src/applications/diffusion/controller/DiffusionBrowseSearchController.php

src/applications/diffusion/controller/DiffusionHistoryController.php

src/applications/diffusion/controller/DiffusionLintDetailsController.php

src/applications/diffusion/controller/DiffusionTagListController.php

src/applications/drydock/controller/DrydockBlueprintViewController.php

src/applications/drydock/controller/DrydockLeaseViewController.php

src/applications/drydock/controller/DrydockResourceViewController.php

src/applications/phame/controller/blog/PhameBlogListController.php

src/applications/phriction/controller/PhrictionHistoryController.php

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

src/applications/tokens/controller/PhabricatorTokenLeaderController.php

src/applications/uiexample/examples/PhabricatorPagerUIExample.php

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php

src/infrastructure/query/PhabricatorOffsetPagedQuery.php

src/view/control/AphrontCursorPagerView.php

src/view/control/AphrontPagerView.php

src/view/phui/PHUIButtonView.php

src/view/phui/PHUIPagerView.php

webroot/rsrc/css/aphront/pager-view.css

webroot/rsrc/css/phui/phui-button.css

webroot/rsrc/css/phui/phui-pager.css

[Redesign] PHUIPagerView
ClosedPublic
Actions

Revision Contents
Changeset List