Page MenuHomePhabricator
Differential D13075

Edit recurring ghost events, not recurring event.
ClosedPublic
Actions

Authored by lpriestley on May 30 2015, 6:52 PM.
Tags
None
Referenced Files
F15540420: D13075.id31577.diff
Fri, Apr 25, 7:26 AM
F15525889: D13075.diff
Mon, Apr 21, 5:36 PM
F15524392: D13075.id31541.diff
Mon, Apr 21, 7:43 AM
F15512497: D13075.diff
Thu, Apr 17, 11:17 AM
F15482060: D13075.id31577.diff
Wed, Apr 9, 2:32 AM
F15481238: D13075.id31541.diff
Tue, Apr 8, 7:18 PM
F15480497: D13075.id31542.diff
Tue, Apr 8, 2:29 PM
F15473274: D13075.id.diff
Sat, Apr 5, 8:49 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8358: Make recurring ghost events editable.
Commits
Restricted Diffusion Commit
rP65d9c0ea24f7: Edit recurring ghost events, not recurring event.
Summary

Closes T8358, Edit recurring ghost events, not recurring event.

Test Plan

Create recurring event, original event should not be editable, but ghost events should be editable.

Diff Detail

Repository
rP Phabricator
Branch
calendareditghostevents
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6372
Build 6394: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31541.May 30 2015, 6:52 PM
lpriestley retitled this revision from to Edit recurring ghost events, not recurring event..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8358: Make recurring ghost events editable..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 30 2015, 6:52 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley added inline comments.May 30 2015, 6:53 PM
src/applications/calendar/storage/PhabricatorCalendarEvent.php
398

Oops. Gotta figure out what to do with this.

lpriestley updated this revision to Diff 31542.May 30 2015, 6:56 PM
lpriestley edited edge metadata.

Better properties for real ghost events

epriestley accepted this revision.May 31 2015, 2:29 PM
epriestley edited edge metadata.

spooky!

This revision is now accepted and ready to land.May 31 2015, 2:29 PM
Closed by commit rP65d9c0ea24f7: Edit recurring ghost events, not recurring event. (authored by lpriestley, committed by lpriestley). · Explain WhyMay 31 2015, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31542

View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility