Page MenuHomePhabricator
Differential D13068

Ghost events should provide a link to original event
ClosedPublic
Actions

Authored by lpriestley on May 29 2015, 5:19 PM.
Tags
None
Referenced Files
F18616944: D13068.diff
Sun, Sep 14, 7:39 PM
F18599697: D13068.id.diff
Sat, Sep 13, 8:00 AM
F18595214: D13068.diff
Fri, Sep 12, 8:55 PM
F18589177: D13068.id31529.diff
Fri, Sep 12, 2:43 AM
F18586289: D13068.id31530.diff
Thu, Sep 11, 6:07 PM
F18586008: D13068.id31531.diff
Thu, Sep 11, 5:07 PM
F18585944: D13068.id31531.diff
Thu, Sep 11, 4:56 PM
F18585873: D13068.id31529.diff
Thu, Sep 11, 4:41 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8356: Ghost events should offer a link back to the original recurring event.
Commits
Restricted Diffusion Commit
rP3d40a5871dd2: Ghost events should provide a link to original event
Summary

Closes T8356, Ghost events should provide a link to original event

Test Plan

Open an instance at /calendar/event/{id}/{index}. It should have a link to /calendar/event/{id}. Original recurring event should not link to itself.

Diff Detail

Repository
rP Phabricator
Branch
calendarrecurringproperties
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6362
Build 6384: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31529.May 29 2015, 5:19 PM
lpriestley retitled this revision from to Ghost events should provide a link to original event.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8356: Ghost events should offer a link back to the original recurring event..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2015, 5:19 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 29 2015, 8:37 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
223

unused

This revision is now accepted and ready to land.May 29 2015, 8:37 PM
lpriestley updated this revision to Diff 31530.May 29 2015, 8:58 PM
lpriestley marked an inline comment as done.
lpriestley edited edge metadata.

unused

Closed by commit rP3d40a5871dd2: Ghost events should provide a link to original event (authored by lpriestley, committed by lpriestley). · Explain WhyMay 29 2015, 8:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
8 lines
storage/
4 lines
2 lines

Diff 31529

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility