Page MenuHomePhabricator

Add a "differential.getrevisiontransactions" method
AbandonedPublic

Authored by joshuaspence on May 29 2015, 4:15 AM.

Details

Summary

Add a differential.getrevisiontransactions method to Conduit. This was requested by a colleague who wanted to query the status of diffs in a given revision. Originally I thought that this should maybe wait until after T5873, but given that we already have a maniphest.gettasktransactions method I figured that maybe this is fine to just add now.

Test Plan

Ran echo '{"ids": [1]}' | arc --conduit-uri='http://phabricator.local' call-conduit 'differential.getrevisiontransactions' and saw expected results.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 6379
Build 6401: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add a `differential.getrevisiontransactions` method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence retitled this revision from Add a `differential.getrevisiontransactions` method to Add a "differential.getrevisiontransactions" method.May 31 2015, 2:01 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited the test plan for this revision. (Show Details)May 31 2015, 2:08 AM

Minor tidying

epriestley requested changes to this revision.May 31 2015, 2:34 PM
epriestley edited edge metadata.

Yeah, I want to wait until T5873 for this since I don't have enough of a plan here yet to have any level of confidence that this is even approximately the way forward.

For example, I suspect this may be more like transactions.query after T5873.

You could drop this into src/extensions/ locally in the meantime.

This revision now requires changes to proceed.May 31 2015, 2:34 PM

(Code itself looks fine to me.)

joshuaspence abandoned this revision.Jun 1 2015, 12:04 AM

Thanks for taking a look.