Page MenuHomePhabricator
Differential D13031

Don't consider strings with variables to be static
ClosedPublic
Actions

Authored by joshuaspence on May 26 2015, 11:44 PM.
Tags
None
Referenced Files
F18055759: D13031.id31551.diff
Mon, Aug 4, 7:43 AM
F18050061: D13031.id31551.diff
Sun, Aug 3, 6:25 PM
F17973180: D13031.id.diff
Fri, Aug 1, 3:57 PM
F17946185: D13031.diff
Thu, Jul 31, 1:45 PM
Unknown Object (File)
Jun 30 2025, 3:24 PM
Unknown Object (File)
Jun 30 2025, 1:37 PM
Unknown Object (File)
May 30 2025, 12:32 PM
Unknown Object (File)
May 29 2025, 2:44 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUa9e581f6488f: Don't consider strings with variables to be static
Summary

This is related to T8049. Maybe I am misinterpreting what the evalStatic method is meant to do, but I don't think that evalStatic should work on strings which contain interpolated variables.

Test Plan

Unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31419.May 26 2015, 11:44 PM
joshuaspence retitled this revision from to Don't consider strings with variables to be static.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 26 2015, 11:44 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a comment.May 27 2015, 9:07 PM

Alternatively, I could just try to implement T8049 properly.

epriestley accepted this revision.May 28 2015, 10:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2015, 10:25 PM
Closed by commit rPHUa9e581f6488f: Don't consider strings with variables to be static (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 31 2015, 12:32 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in T8379: ArcanistFormattedStringXHPASTLinterRule fails.Jun 1 2015, 9:42 PM

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
api/
24 lines
__tests__/
3 lines

Diff 31551

View Options

src/parser/xhpast/api/XHPASTNode.php

Loading...
View Options

src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php

Loading...
Phabricator · Built by Phacility