Page MenuHomePhabricator

Don't consider strings with variables to be static
ClosedPublic

Authored by joshuaspence on May 26 2015, 11:44 PM.

Details

Summary

This is related to T8049. Maybe I am misinterpreting what the evalStatic method is meant to do, but I don't think that evalStatic should work on strings which contain interpolated variables.

Test Plan

Unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't consider strings with variables to be static.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Alternatively, I could just try to implement T8049 properly.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2015, 10:25 PM
This revision was automatically updated to reflect the committed changes.