Fix invalid parameter in phutil_console_wrap()
ClosedPublic
Actions

Authored by nevogd on May 26 2015, 12:55 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8314: arc diff causes exception if no reviewers are specified

Commits

rARC407af00ef613: Fix invalid parameter in phutil_console_wrap()

Summary

Fixes T8314. Change the phutil_console_wrap() call to only have a single
string parameter.

Test Plan

Ran arc diff added text into the title, summary and test plan fields,
but did not specify any reviewers. When prompted to continue, clicked 'No' and
saw the '(Message saved to commit message.)' string.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nevogd updated this revision to Diff 31388.May 26 2015, 12:55 PM

nevogd retitled this revision from to Fix invalid parameter in phutil_console_wrap().

nevogd updated this object.

nevogd edited the test plan for this revision. (Show Details)

nevogd added a task: T8314: arc diff causes exception if no reviewers are specified.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 26 2015, 12:55 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.May 26 2015, 1:06 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.May 26 2015, 1:06 PM

Thanks!

Closed by commit rARC407af00ef613: Fix invalid parameter in phutil_console_wrap() (authored by nevogd, committed by epriestley). · Explain WhyMay 26 2015, 1:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

6 lines

Diff 31390

View Options

src/workflow/ArcanistDiffWorkflow.php

Fix invalid parameter in phutil_console_wrap()ClosedPublicActions