Paths

Table of Contentst

Differential D12999

Remove reentrant code
ClosedPublic
Actions

Authored by joshuaspence on May 25 2015, 12:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 5:03 AM

	Unknown Object (File)
	Fri, Dec 6, 1:01 PM

	Unknown Object (File)
	Thu, Dec 5, 4:03 PM

	Unknown Object (File)
	Wed, Dec 4, 2:29 PM

	Unknown Object (File)
	Sun, Nov 24, 8:30 PM

	Unknown Object (File)
	Nov 22 2024, 8:38 AM

	Unknown Object (File)
	Nov 22 2024, 7:57 AM

	Unknown Object (File)
	Nov 22 2024, 4:34 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7604: Remove "Arcanist Projects"

Commits

rARC92dbc36250bd: Remove reentrant code

Summary

Ref T7604. Remove the reenter_if_this_is_arcanist_or_libphutil function. Some discussion in D12945.

Test Plan

Ran ./bin/arc --trace help and saw things happen as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31346.May 25 2015, 12:18 PM

joshuaspence retitled this revision from to Remove reentrant code.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7604: Remove "Arcanist Projects".

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 12:18 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D12945: Remove arcanist projects from working copy code.May 25 2015, 12:19 PM

ARC_PHUTIL_PATH can likely be removed from whatever references it now, too, I think?

This revision is now accepted and ready to land.May 25 2015, 12:19 PM

I suppose it doesn't necessarily hurt anything to leave it.

Yeah I think we should just leave it.

I can't manage to reproduce it now, but I somehow got this error:

Usage Exception: You are trying to run one copy of Arcanist on another copy of Arcanist. This operation is not supported. To execute Arcanist operations against this working copy, run `./bin/arc` (from the current working copy) not some other copy of 'arc'

Assuming you were actually doing that (i.e., the error is not a false positive), I think that's fine/desirable (it addresses the confusing case above, and shouldn't ever impact any normal users).

Yeah it wasn't a false positive... I just thought it had to do with the reentrant stuff.

joshuaspence added a child revision: D13002: Remove "project.name" from `.arcconfig".May 25 2015, 12:41 PM

joshuaspence added a child revision: D13003: Remove "project.name" from `.arcconfig".

Closed by commit rARC92dbc36250bd: Remove reentrant code (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 12:42 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in T8321: Re-enable reentrant code.May 26 2015, 9:25 PM

Revision Contents
Changeset List

Path

Size

scripts/

77 lines

Diff 31357

scripts/arcanist.php

Loading...