Page MenuHomePhabricator
Differential D12998

Fix custom field selector control in cases where the user doesn't edit anything
ClosedPublic
Actions

Authored by epriestley on May 25 2015, 12:13 PM.
Tags
None
Referenced Files
F13179763: D12998.diff
Wed, May 8, 9:25 PM
Unknown Object (File)
Sat, May 4, 7:03 PM
Unknown Object (File)
Wed, May 1, 12:32 AM
Unknown Object (File)
Sat, Apr 27, 12:36 AM
Unknown Object (File)
Wed, Apr 24, 7:32 AM
Unknown Object (File)
Sat, Apr 20, 3:04 AM
Unknown Object (File)
Fri, Apr 19, 11:54 PM
Unknown Object (File)
Fri, Apr 19, 11:54 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
Commits
Restricted Diffusion Commit
rP969a6a2b38b6: Fix custom field selector control in cases where the user doesn't edit anything
Summary

The JS and PHP representations of state can differ; just have the JS write the state out immediately on page load.

Test Plan

Saved diffusion.fields without making changes, reloaded, saw no effective change.

Diff Detail

Repository
rP Phabricator
Branch
writeform
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6256
Build 6278: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31345.May 25 2015, 12:13 PM
epriestley retitled this revision from to Fix custom field selector control in cases where the user doesn't edit anything.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2015, 12:13 PM
joshuaspence accepted this revision.May 25 2015, 12:15 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 12:15 PM
Closed by commit rP969a6a2b38b6: Fix custom field selector control in cases where the user doesn't edit anything (authored by epriestley, committed by epriestley). · Explain WhyMay 25 2015, 12:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
infrastructure/
customfield/
config/
5 lines
webroot/
rsrc/
js/
application/
config/
1 line

Diff 31345

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

Loading...
View Options

webroot/rsrc/js/application/config/behavior-reorder-fields.js

Loading...
Phabricator · Built by Phacility