Page MenuHomePhabricator
Differential D12996

Fix some format strings
ClosedPublic
Actions

Authored by joshuaspence on May 25 2015, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 4:51 AM
Unknown Object (File)
Sat, Feb 8, 4:51 AM
Unknown Object (File)
Sat, Feb 8, 4:51 AM
Unknown Object (File)
Sat, Feb 8, 4:51 AM
Unknown Object (File)
Sat, Feb 8, 4:51 AM
Unknown Object (File)
Sun, Feb 2, 7:53 AM
Unknown Object (File)
Tue, Jan 28, 11:47 PM
Unknown Object (File)
Tue, Jan 28, 3:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP1b12249b2ca3: Fix some format strings
Summary

These format strings use %d instead of %s.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31335.May 25 2015, 11:25 AM
joshuaspence retitled this revision from to Fix some format strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 11:25 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 25 2015, 11:27 AM
epriestley edited edge metadata.

What's up with those test failures?

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
59–60 ↗(On Diff #31335)

not 100% sure this works without pht()?

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php
72 ↗(On Diff #31335)

This one proably isn't right, since it's sprintf() [not pht()].

This revision is now accepted and ready to land.May 25 2015, 11:27 AM
joshuaspence marked 2 inline comments as done.May 25 2015, 11:30 AM
joshuaspence added inline comments.
src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
59–60 ↗(On Diff #31335)

I figured it would be cast to a string due to the string concatenation... although PhutilNumber doesn't have a __toString method so I don't know how this all works.

joshuaspence updated this revision to Diff 31336.May 25 2015, 11:30 AM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Smaller changeset

Closed by commit rP1b12249b2ca3: Fix some format strings (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
3 lines
diffusion/
controller/
4 lines
repository/
management/
4 lines

Diff 31337

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

Loading...
Phabricator · Built by Phacility