Page MenuHomePhabricator

Fix some format strings
ClosedPublic

Authored by joshuaspence on May 25 2015, 11:25 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP1b12249b2ca3: Fix some format strings
Summary

These format strings use %d instead of %s.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix some format strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

What's up with those test failures?

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
59–60 ↗(On Diff #31335)

not 100% sure this works without pht()?

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php
72 ↗(On Diff #31335)

This one proably isn't right, since it's sprintf() [not pht()].

This revision is now accepted and ready to land.May 25 2015, 11:27 AM
joshuaspence added inline comments.
src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
59–60 ↗(On Diff #31335)

I figured it would be cast to a string due to the string concatenation... although PhutilNumber doesn't have a __toString method so I don't know how this all works.

joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Smaller changeset

This revision was automatically updated to reflect the committed changes.