Fix some format strings
ClosedPublic
Actions

Authored by joshuaspence on May 25 2015, 11:25 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Summary

These format strings use %d instead of %s.

Test Plan

Eyeball it.

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6249
Build 6271: [Placeholder Plan] Wait for 30 Seconds

	Time	Test
	1 ms	AphrontIsolatedDatabaseConnectionTestCase::testTransactionRollback
	1 ms	AphrontMySQLDatabaseConnectionTestCase::testConnectionFailures
	0 ms	AphrontIsolatedDatabaseConnectionTestCase::testDeletePermitted
	0 ms	AphrontIsolatedDatabaseConnectionTestCase::testInsertGeneratesID
	0 ms	AphrontIsolatedDatabaseConnectionTestCase::testIsolation
		View Full Test Results (2 Failed · 24 Passed)

joshuaspence retitled this revision from to Fix some format strings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

What's up with those test failures?

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
59–60	not 100% sure this works without pht()?
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php
72	This one proably isn't right, since it's sprintf() [not pht()].

This revision is now accepted and ready to land.May 25 2015, 11:27 AM

joshuaspence marked 2 inline comments as done.May 25 2015, 11:30 AM

joshuaspence added inline comments.

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php
59–60	I figured it would be cast to a string due to the string concatenation... although `PhutilNumber` doesn't have a `__toString` method so I don't know how this all works.