Page MenuHomePhabricator
Differential D12961

[Redesign] PHUIHeaderView goes to table layout
ClosedPublic
Actions

Authored by chad on May 21 2015, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 4:54 AM
Unknown Object (File)
Tue, Jan 21, 12:02 PM
Unknown Object (File)
Tue, Jan 21, 10:03 AM
Unknown Object (File)
Sat, Jan 18, 12:26 AM
Unknown Object (File)
Thu, Jan 2, 9:42 PM
Unknown Object (File)
Tue, Dec 31, 4:47 PM
Unknown Object (File)
Dec 12 2024, 7:42 PM
Unknown Object (File)
Dec 2 2024, 9:12 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP3cd27a0881b1: [Redesign] PHUIHeaderView goes to table layout
Summary

Ref T8099. This changes makes flexible layouts easier, and aligns icons, buttons better vertically.

Test Plan

Test various header locations, Phriction, Conpherence, Dashboards, Workboards etc.

Diff Detail

Repository
rP Phabricator
Branch
phui-header-table-view
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6172
Build 6193: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 31218.May 21 2015, 4:06 AM
chad retitled this revision from to [Redesign] PHUIHeaderView goes to table layout.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 21 2015, 4:06 AM
chad updated this revision to Diff 31222.May 21 2015, 5:21 AM
  • Clean up some Diffusion layouts
chad added a comment.May 22 2015, 2:31 PM

3ea373bea61d2c176b2dbf060cde4b31.gif (230×500 px, 962 KB)

epriestley accepted this revision.May 22 2015, 2:34 PM
epriestley edited edge metadata.

I am only saddened that this is a fake CSS table rather than a wholesome, red-blooded, hard-working American <table /> tag.

This revision is now accepted and ready to land.May 22 2015, 2:34 PM
Closed by commit rP3cd27a0881b1: [Redesign] PHUIHeaderView goes to table layout (authored by chad, committed by chad). · Explain WhyMay 22 2015, 3:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
src/
view/
phui/
76 lines
webroot/
rsrc/
css/
application/
conpherence/
4 lines
layout/
10 lines
phui/
2 lines
43 lines
14 lines
4 lines
2 lines

Diff 31218

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/widget-pane.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-hovercard-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workboard-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workpanel-view.css

Loading...
Phabricator · Built by Phacility