Page MenuHomePhabricator
Differential D12937

Transactions - finish making built-in transaction types implementation optional
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 3:01 PM
Unknown Object (File)
Thu, Feb 20, 8:39 PM
Unknown Object (File)
Wed, Feb 19, 1:48 AM
Unknown Object (File)
Tue, Feb 11, 9:12 PM
Unknown Object (File)
Tue, Feb 11, 7:11 AM
Unknown Object (File)
Sat, Feb 8, 4:45 AM
Unknown Object (File)
Sat, Feb 8, 4:45 AM
Unknown Object (File)
Sat, Feb 8, 4:45 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
Commits
Restricted Diffusion Commit
rP4787069e96fb: Transactions - finish making built-in transaction types implementation optional
Summary

Fixes T6403. Remaining built-ins were already built-in effectively so this is a small re-factor plus some docs. I probably wouldn't have written anything if not for the TODO so please feel free to tell me to write something else or what have you.

Test Plan

NA since this didn't actually change anything.

Diff Detail

Repository
rP Phabricator
Branch
T6403
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6134
Build 6155: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31140.May 19 2015, 8:44 PM
btrahan added a task: T6403: Make application customization of builtin transaction types optional.
btrahan retitled this revision from to Transactions - finish making built-in transaction types implementation optional.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 8:44 PM
epriestley accepted this revision.May 19 2015, 11:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 11:06 PM
Closed by commit rP4787069e96fb: Transactions - finish making built-in transaction types implementation optional (authored by btrahan, committed by btrahan). · Explain WhyMay 20 2015, 8:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
29 lines

Diff 31140

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility