Paths

Table of Contentst

Differential D12934

Calendar events should actually have an icon now.
ClosedPublic
Actions

Authored by lpriestley on May 19 2015, 7:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 11:50 PM

	Unknown Object (File)
	Sat, Jan 25, 5:06 PM

	Unknown Object (File)
	Fri, Jan 24, 3:16 PM

	Unknown Object (File)
	Fri, Jan 24, 4:49 AM

	Unknown Object (File)
	Fri, Jan 24, 4:49 AM

	Unknown Object (File)
	Wed, Jan 22, 4:39 PM

	Unknown Object (File)
	Fri, Jan 17, 8:15 PM

	Unknown Object (File)
	Fri, Jan 17, 6:31 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7936: Give Calendar events custom icons

Commits

Restricted Diffusion Commit
rP3845057efb8b: Calendar events should actually have an icon now.

Summary

Ref T7936, Calendar events should actually have an icon now.

Test Plan

Edit event, edit icon, save, observe transaction feed.

Diff Detail

Repository

Branch

calendareventiconedit

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6129
Build 6150: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31132.May 19 2015, 7:54 PM

lpriestley retitled this revision from to Calendar events should actually have an icon now..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7936: Give Calendar events custom icons.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2015, 7:54 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

blast the ph

epriestley accepted this revision.May 19 2015, 7:58 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
197	Move this down and create a new block for it which just does `break;` without doing `$invalidate_all = true;` -- we don't need to invalidate availability caches when an icon changes.
src/applications/calendar/icon/PhabricatorCalendarIcon.php
15	I'd prefer to avoid using a company logo, how about `fa-birthday-cake` instead?

This revision is now accepted and ready to land.May 19 2015, 7:58 PM

changing icons. because fun police.

Closed by commit rP3845057efb8b: Calendar events should actually have an icon now. (authored by lpriestley, committed by lpriestley). · Explain WhyMay 19 2015, 8:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

sql/

autopatches/

20150519.calendar.calendaricon.sql

5 lines

src/

applications/

calendar/

controller/

PhabricatorCalendarEventEditController.php

27 lines

PhabricatorCalendarEventViewController.php

6 lines

editor/

PhabricatorCalendarEventEditor.php

11 lines

icon/

PhabricatorCalendarIcon.php

32 lines

storage/

PhabricatorCalendarEvent.php

5 lines

PhabricatorCalendarEventTransaction.php

16 lines

Diff 31132

resources/celerity/map.php

Loading...

resources/sql/autopatches/20150519.calendar.calendaricon.sql

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/calendar/icon/PhabricatorCalendarIcon.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...