Page MenuHomePhabricator

Calendar events should actually have an icon now.
ClosedPublic

Authored by lpriestley on May 19 2015, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 4:07 PM
Unknown Object (File)
Sun, Mar 24, 10:49 AM
Unknown Object (File)
Sun, Mar 17, 3:25 AM
Unknown Object (File)
Sun, Mar 17, 3:25 AM
Unknown Object (File)
Sun, Mar 17, 3:25 AM
Unknown Object (File)
Feb 3 2024, 3:48 PM
Unknown Object (File)
Feb 1 2024, 11:23 AM
Unknown Object (File)
Jan 27 2024, 8:14 AM
Subscribers

Details

Summary

Ref T7936, Calendar events should actually have an icon now.

Test Plan

Edit event, edit icon, save, observe transaction feed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Calendar events should actually have an icon now..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
188

Move this down and create a new block for it which just does break; without doing $invalidate_all = true; -- we don't need to invalidate availability caches when an icon changes.

src/applications/calendar/icon/PhabricatorCalendarIcon.php
15

I'd prefer to avoid using a company logo, how about fa-birthday-cake instead?

This revision is now accepted and ready to land.May 19 2015, 7:58 PM
lpriestley edited edge metadata.

changing icons. because fun police.

This revision was automatically updated to reflect the committed changes.