Page MenuHomePhabricator
Differential D12933

Transactions - make implementing TYPE_XXXX_POLICY transactions optional
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 7:47 PM.
Tags
None
Referenced Files
F14478444: D12933.diff
Sat, Dec 28, 6:06 PM
Unknown Object (File)
Mon, Dec 23, 7:36 AM
Unknown Object (File)
Mon, Dec 23, 7:36 AM
Unknown Object (File)
Mon, Dec 23, 7:36 AM
Unknown Object (File)
Mon, Dec 23, 6:31 AM
Unknown Object (File)
Fri, Dec 13, 3:09 PM
Unknown Object (File)
Sun, Dec 8, 11:40 AM
Unknown Object (File)
Thu, Dec 5, 11:46 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
Commits
Restricted Diffusion Commit
rP81a475d5a6b4: Transactions - make implementing TYPE_XXXX_POLICY transactions optional
Summary

Ref T6403. This was actually simple stuff.

Test Plan

changed the edit policy of a paste. changed the edit and join policy of a phame blog.

Diff Detail

Repository
rP Phabricator
Branch
T6403
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6128
Build 6149: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31131.May 19 2015, 7:47 PM
btrahan added a task: T6403: Make application customization of builtin transaction types optional.
btrahan retitled this revision from to Transactions - make implementing TYPE_XXXX_POLICY transactions optional.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 7:47 PM
epriestley accepted this revision.May 19 2015, 7:52 PM
epriestley edited edge metadata.

whelp

This revision is now accepted and ready to land.May 19 2015, 7:52 PM
Closed by commit rP81a475d5a6b4: Transactions - make implementing TYPE_XXXX_POLICY transactions optional (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 7:58 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D13144: Fix an issue with AlamancDeviceEditor.Jun 3 2015, 9:55 PM
epriestley added a comment.Jun 3 2015, 9:58 PM

I went through these again and think this was the only one that was missed.

src/applications/almanac/editor/AlmanacDeviceEditor.php
74

See D13144.

epriestley mentioned this in rP8928aa2b67b5: Fix an issue with AlamancDeviceEditor.Jun 4 2015, 1:41 AM

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
editor/
5 lines
5 lines
5 lines
calendar/
editor/
5 lines
dashboard/
editor/
8 lines
8 lines
differential/
editor/
4 lines
15 lines
files/
editor/
3 lines
fund/
editor/
6 lines
passphrase/
editor/
8 lines
paste/
editor/
8 lines
phame/
editor/
12 lines
phlux/
editor/
8 lines
phortune/
editor/
3 lines
project/
editor/
12 lines
transactions/
editor/
29 lines

Diff 31131

View Options

src/applications/almanac/editor/AlmanacDeviceEditor.php

Loading...
View Options

src/applications/almanac/editor/AlmanacNetworkEditor.php

Loading...
View Options

src/applications/almanac/editor/AlmanacServiceEditor.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...
View Options

src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialDiffEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/files/editor/PhabricatorFileEditor.php

Loading...
View Options

src/applications/fund/editor/FundInitiativeEditor.php

Loading...
View Options

src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php

Loading...
View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditor.php

Loading...
View Options

src/applications/phlux/editor/PhluxVariableEditor.php

Loading...
View Options

src/applications/phortune/editor/PhortuneMerchantEditor.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility