Page MenuHomePhabricator
Differential D12930

Transactions - move TYPE_SUBSCRIBERS to require optional implementation
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 6:40 PM.
Tags
None
Referenced Files
F14059304: D12930.diff
Sun, Nov 17, 6:54 PM
F14047397: D12930.diff
Thu, Nov 14, 3:46 AM
F14036131: D12930.diff
Sun, Nov 10, 8:37 AM
F14021262: D12930.diff
Wed, Nov 6, 6:52 AM
F13974932: D12930.id.diff
Oct 18 2024, 7:58 AM
F13973318: D12930.diff
Oct 18 2024, 12:23 AM
F13971307: D12930.id31124.diff
Oct 17 2024, 12:46 PM
F13965849: D12930.diff
Oct 16 2024, 4:37 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
Commits
Restricted Diffusion Commit
rP18e0ee079132: Transactions - move TYPE_SUBSCRIBERS to require optional implementation
Summary

Ref T6403. This one was pretty easy since no one does anything custom with subscribers.

Test Plan

subscribed / unscribed to a random commit ("audit"). joined / left, watched / unwatched a project

Diff Detail

Repository
rP Phabricator
Branch
T6403
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6123
Build 6144: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31123.May 19 2015, 6:40 PM
btrahan added a task: T6403: Make application customization of builtin transaction types optional.
btrahan retitled this revision from to Transactions - move TYPE_SUBSCRIBERS to require optional implementation.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 6:40 PM
epriestley accepted this revision.May 19 2015, 6:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 6:45 PM
epriestley awarded a token.May 19 2015, 6:45 PM
btrahan added a comment.May 19 2015, 6:47 PM

Imma take all your hay pennies! :D

Closed by commit rP18e0ee079132: Transactions - move TYPE_SUBSCRIBERS to require optional implementation (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
2 lines
calendar/
editor/
2 lines
differential/
editor/
2 lines
fund/
editor/
2 lines
paste/
editor/
2 lines
project/
editor/
3 lines
transactions/
editor/
3 lines

Diff 31123

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/fund/editor/FundInitiativeEditor.php

Loading...
View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility