Page MenuHomePhabricator

Skeleton of calendar icon infrastructure
ClosedPublic

Authored by lpriestley on May 19 2015, 5:58 PM.

Details

Summary

Ref T7936, Skeleton of calendar icon infrastructure

Test Plan

Navigate to install/calendar/icon/, observe temporary calendar icons

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Skeleton of calendar icon infrastructure.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php
8–13

Prefer the slightly more modern/simpler: handleRequest(AphrontRequest $request) method (instead of processRequest()) then $id = $request->getURIData('id');, and pull $viewer with $this->getViewer().

30

Trailing slash probably incorrect?

This revision is now accepted and ready to land.May 19 2015, 6:10 PM
lpriestley marked an inline comment as done.
lpriestley edited edge metadata.

retro-garbage

This revision was automatically updated to reflect the committed changes.