Paths

Table of Contentst

Differential D12928

Skeleton of calendar icon infrastructure
ClosedPublic
Actions

Authored by lpriestley on May 19 2015, 5:58 PM.

Tags

None

Referenced Files

	F15310346: D12928.diff
	Thu, Mar 6, 8:59 AM

	Unknown Object (File)
	Mon, Feb 24, 8:40 AM

	Unknown Object (File)
	Sat, Feb 22, 4:38 AM

	Unknown Object (File)
	Sat, Feb 22, 1:39 AM

	Unknown Object (File)
	Sun, Feb 9, 6:35 PM

	Unknown Object (File)
	Sat, Feb 8, 4:44 AM

	Unknown Object (File)
	Sat, Feb 8, 4:44 AM

	Unknown Object (File)
	Fri, Feb 7, 10:47 PM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7936: Give Calendar events custom icons

Commits

Restricted Diffusion Commit
rP7bc008d0e2cc: Skeleton of calendar icon infrastructure

Summary

Ref T7936, Skeleton of calendar icon infrastructure

Test Plan

Navigate to install/calendar/icon/, observe temporary calendar icons

Diff Detail

Repository

Branch

calendaricons

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6120
Build 6141: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31116.May 19 2015, 5:58 PM

lpriestley retitled this revision from to Skeleton of calendar icon infrastructure.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7936: Give Calendar events custom icons.

Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 19 2015, 5:58 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 19 2015, 6:09 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php
7–12	Prefer the slightly more modern/simpler: `handleRequest(AphrontRequest $request)` method (instead of `processRequest()`) then `$id = $request->getURIData('id');`, and pull `$viewer` with `$this->getViewer()`.
29	Trailing slash probably incorrect?

This revision is now accepted and ready to land.May 19 2015, 6:10 PM

retro-garbage

Closed by commit rP7bc008d0e2cc: Skeleton of calendar icon infrastructure (authored by lpriestley, committed by lpriestley). · Explain WhyMay 19 2015, 6:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

__phutil_library_map__.php

4 lines

applications/

calendar/

application/

PhabricatorCalendarApplication.php

4 lines

controller/

PhabricatorCalendarEventEditIconController.php

103 lines

icon/

PhabricatorCalendarIcon.php

49 lines

webroot/

rsrc/

css/

application/

calendar/

calendar-icon.css

28 lines

Diff 31116

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventEditIconController.php

Loading...

src/applications/calendar/icon/PhabricatorCalendarIcon.php

Loading...

webroot/rsrc/css/application/calendar/calendar-icon.css

Loading...