Differential D12922

Add linter rule for invalid modifiers
ClosedPublic
Actions

Authored by joshuaspence on May 19 2015, 11:13 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC097c894d0831: Add linter rule for invalid modifiers

Summary

Add some linter rule to detect invalid modifiers for class methods/properties.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6143
Build 6164: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31088.May 19 2015, 11:13 AM

joshuaspence retitled this revision from to Add linter rule for invalid modifiers.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2015, 11:13 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 19 2015, 12:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 12:59 PM

Rebase

Closed by commit rARC097c894d0831: Add linter rule for invalid modifiers (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:47 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in T6154: XHPAST fails to recognise some syntax errors.May 27 2015, 9:28 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

113 lines

__tests__/

xhpast/

invalid-modifiers.lint-test

18 lines

Diff 31170

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/invalid-modifiers.lint-test

Add linter rule for invalid modifiersClosedPublicActions