Paths

Table of Contentst

Differential D12856

Add a linter rule for the instanceof operator
ClosedPublic
Actions

Authored by joshuaspence on May 15 2015, 10:15 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC4bb2eecdaf42: Add a linter rule for the instanceof operator

Summary

The instanceof operator expects the first argument to be an object instance. See http://www.phpwtf.org/instanceof-smart.

Test Plan

Added test case

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6056
Build 6076: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30926.May 15 2015, 10:15 AM

joshuaspence retitled this revision from to Add a linter rule for the instanceof operator.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 10:15 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 17 2015, 12:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2015, 12:58 PM

joshuaspence updated this object.May 18 2015, 7:58 AM

joshuaspence edited edge metadata.

Rebase

Closed by commit rARC4bb2eecdaf42: Add a linter rule for the instanceof operator (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 18 2015, 8:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

30 lines

__tests__/

xhpast/

instanceof-operator.lint-test

9 lines

Diff 31014

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/instanceof-operator.lint-test

Add a linter rule for the instanceof operatorClosedPublicActions