Fix "not(project)" in Diffusion
ClosedPublic
Actions

Authored by epriestley on May 7 2015, 12:21 PM.

Details

Reviewers

btrahan
avivey

Maniphest Tasks

T8105: Diffusion search for "not in project" doesn't work

Commits

Restricted Diffusion Commit
rP1c399476798f: Fix "not(project)" in Diffusion

Summary

Fixes T8105. We weren't including the parent WHERE clause fragment correctly.

Test Plan

Used not(project) in a query.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30630.May 7 2015, 12:21 PM

epriestley retitled this revision from to Fix "not(project)" in Diffusion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8105: Diffusion search for "not in project" doesn't work.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 7 2015, 12:21 PM

looks right...

This revision is now accepted and ready to land.May 7 2015, 4:32 PM

Closed by commit rP1c399476798f: Fix "not(project)" in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMay 7 2015, 5:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

repository/

query/

PhabricatorRepositoryQuery.php

10 lines

Diff 30643

View Options

src/__phutil_library_map__.php