Closes T8048, Calendar event detail view should show "Unnamed Event" as title for events with no title
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8048: Calendar Event pages should always have some title
- Commits
- Restricted Diffusion Commit
rPbcf60f1b05b9: Calendar event detail view should show "Unnamed Event" as title for events…
Open an old event created before titles were required, event detail view should display title as "Unnamed Event" instead of a blank title
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarunnamedevents
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5798 Build 5817: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Hy,
I get the following exception when i try to run migration on my install.
[2015-05-15 09:03:33] EXCEPTION: (AphrontSchemaQueryException) #1054: Unknown column 'profileImageCache' in 'field list' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:308]
arcanist(head=master, ref.master=e1a051a033b8), phabricator(head=master, ref.master=e185d8fe0234), phutil(head=master, ref.master=afc60bc131e1)
#0 AphrontBaseMySQLDatabaseConnection::throwQueryCodeException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:275] #1 AphrontBaseMySQLDatabaseConnection::throwQueryException(mysqli) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:181] #2 AphrontBaseMySQLDatabaseConnection::executeRawQuery(string) called at [<phutil>/src/xsprintf/queryfx.php:6] #3 queryfx(AphrontMySQLiDatabaseConnection, string, string, string, string) called at [<phabricator>/src/applications/people/storage/PhabricatorUser.php:856] #4 PhabricatorUser::writeProfileImageCache(string) called at [<phabricator>/src/applications/people/query/PhabricatorPeopleQuery.php:197] #5 PhabricatorPeopleQuery::didFilterPage(array) called at [<phabricator>/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:261] #6 PhabricatorPolicyAwareQuery::execute() called at [<phabricator>/src/applications/phid/type/PhabricatorPHIDType.php:102] #7 PhabricatorPHIDType::loadObjects(PhabricatorObjectQuery, array) called at [<phabricator>/src/applications/phid/query/PhabricatorObjectQuery.php:141] #8 PhabricatorObjectQuery::loadObjectsByPHID(array, array) called at [<phabricator>/src/applications/phid/query/PhabricatorObjectQuery.php:63] #9 PhabricatorObjectQuery::loadPage() called at [<phabricator>/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:228] #10 PhabricatorPolicyAwareQuery::execute() called at [<phabricator>/src/applications/phid/query/PhabricatorHandleQuery.php:25] #11 PhabricatorHandleQuery::loadPage() called at [<phabricator>/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:228] #12 PhabricatorPolicyAwareQuery::execute() called at [<phabricator>/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:168] #13 PhabricatorPolicyAwareQuery::executeOne() called at [<phabricator>/resources/sql/autopatches/20150506.calendarunnamedevents.1.php:17] #14 require_once(string) called at [<phabricator>/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php:226] #15 PhabricatorStorageManagementAPI::applyPatchPHP(string) called at [<phabricator>/src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php:191] #16 PhabricatorStorageManagementAPI::applyPatch(PhabricatorStoragePatch) called at [<phabricator>/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php:177] #17 PhabricatorStorageManagementUpgradeWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:406] #18 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:301] #19 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/sql/manage_storage.php:171]
Comment Actions
Okay, i find the solution, the patches has wrong order. This autopatch run before the actual alters applied to the table, and try to use non exist colums. Here is my storage status and order.
| Migration | Status | Type |
|---|---|---|
| phabricator:20150506.calendarunnamedevents.1.php | Not Applied | php |
| phabricator:20150507.calendar.1.isallday.sql | Not Applied | sql |
| phabricator:20150513.user.cache.1.sql | Not Applied | sql |
| phabricator:20150514.calendar.status.sql | Not Applied | sql |
| phabricator:20150514.phame.blog.xaction.sql | Not Applied | sql |
| phabricator:20150514.user.cache.2.sql | Not Applied | sql |
Used a really hacky way to fix this, run the 2 user cache alters on my db, with hand, it is allow the calendarunnamedevents migration to run, but block the 2 others, removed the three new column from users table and run the migration again. This fixed my problem. But i think this patches needs to be reordered.