Page MenuHomePhabricator

Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod
ClosedPublic

Authored by epriestley on May 5 2015, 10:35 PM.
Tags
None
Referenced Files
F13209697: D12726.id30577.diff
Fri, May 17, 1:44 AM
F13204263: D12726.diff
Wed, May 15, 12:26 AM
F13187142: D12726.diff
Sat, May 11, 4:21 AM
Unknown Object (File)
Tue, May 7, 7:27 AM
Unknown Object (File)
Fri, May 3, 6:17 AM
Unknown Object (File)
Thu, Apr 25, 1:05 AM
Unknown Object (File)
Apr 16 2024, 11:20 PM
Unknown Object (File)
Mar 23 2024, 3:13 PM
Subscribers

Details

Summary

We were adding "+1" to PHP_INT_MAX, which could cause us to wrap and run git log -n -9223372036854775808 .... Git, unable to give us negative nine trillion zillion results, would then exit without producing results.

Test Plan

Got results out of this method.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a bug with DiffusionMergedCommitsQueryConduitAPIMethod.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php
55

Specifically, this is where we'd run into a problem.

btrahan edited edge metadata.
This revision is now accepted and ready to land.May 5 2015, 10:43 PM
This revision was automatically updated to reflect the committed changes.