Page MenuHomePhabricator

Add a preference to disable ghost comments
ClosedPublic

Authored by epriestley on May 4 2015, 6:55 PM.
Tags
None
Referenced Files
F18091189: D12704.id30504.diff
Wed, Aug 6, 8:06 PM
F18083934: D12704.id30502.diff
Tue, Aug 5, 12:31 PM
F18081988: D12704.id.diff
Tue, Aug 5, 3:23 AM
F18077353: D12704.diff
Mon, Aug 4, 7:03 PM
F17872921: D12704.diff
Mon, Jul 28, 4:59 PM
Unknown Object (File)
Jun 4 2025, 6:19 PM
Unknown Object (File)
Jun 3 2025, 2:40 AM
Unknown Object (File)
May 17 2025, 2:43 AM

Details

Summary

Ref T7447. At least some users dislike this feature so strongly that they'd prefer not to have it at all.

Test Plan

Viewed ghosts; toggled preference, no more ghosts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a preference to disable ghost comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

We could add an "Only if not Done" option easily, but bringing "Done" comments forward is so valuable for me that it's hard for me to imagine that this is really a useful setting.

I could perhaps imagine an "On revisions I am the author of, only if not Done" setting, but this seems too complicated and confusing.

chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.