Page MenuHomePhabricator

Add a preference to disable ghost comments
ClosedPublic

Authored by epriestley on May 4 2015, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:10 PM
Unknown Object (File)
Sun, Dec 15, 10:51 AM
Unknown Object (File)
Fri, Dec 6, 6:03 PM
Unknown Object (File)
Fri, Nov 29, 6:53 PM
Unknown Object (File)
Wed, Nov 27, 4:07 AM
Unknown Object (File)
Sun, Nov 24, 12:04 PM
Unknown Object (File)
Nov 19 2024, 3:30 AM
Unknown Object (File)
Nov 18 2024, 4:40 PM

Details

Summary

Ref T7447. At least some users dislike this feature so strongly that they'd prefer not to have it at all.

Test Plan

Viewed ghosts; toggled preference, no more ghosts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a preference to disable ghost comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

We could add an "Only if not Done" option easily, but bringing "Done" comments forward is so valuable for me that it's hard for me to imagine that this is really a useful setting.

I could perhaps imagine an "On revisions I am the author of, only if not Done" setting, but this seems too complicated and confusing.

chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.