Ref T7674. This linter doesn't make sense without commit hooks.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7674: Remove support for arc commit hooks
- Commits
- rARC0846c6aff5c4: Remove commit linter
N/A
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 5734 Build 5753: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 1,818 ms | ArcanistPuppetLintLinterTestCase::testLinter | |
| 1,538 ms | ArcanistXMLLinterTestCase::testLinter | |
| 1,247 ms | ArcanistCSSLintLinterTestCase::testLinter | |
| 154 ms | ArcanistCSSLintLinterTestCase::testVersion | |
| 183 ms | ArcanistChmodLinterTestCase::testLinter | |
| View Full Test Results (2 Failed · 48 Passed · 5 Skipped) |
Event Timeline
Comment Actions
This is still sort of useful, in that you can write something like this, right?
// @nocommit: Just for testing, revert before sending for review!! // $value = real_value(); $value = 42;
I think it's still fine to get rid of since this is super marginal and you can write a similar rule using script+regex or something once it modernizes.
Comment Actions
You could do that, but it doesn't prevent the code from actually being pushed. This makes it significantly less valuable.