Page MenuHomePhabricator
Differential D12678

Use phutil_json_decode instead of json_decode
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 9:14 PM.
Tags
None
Referenced Files
F14776259: D12678.id30469.diff
Fri, Jan 24, 3:55 AM
F14776258: D12678.id30443.diff
Fri, Jan 24, 3:55 AM
F14776257: D12678.id.diff
Fri, Jan 24, 3:55 AM
F14776256: D12678.diff
Fri, Jan 24, 3:55 AM
Unknown Object (File)
Wed, Jan 22, 3:55 AM
Unknown Object (File)
Mon, Jan 20, 12:52 AM
Unknown Object (File)
Tue, Jan 14, 2:53 AM
Unknown Object (File)
Wed, Jan 8, 1:14 PM
View All Files
Subscribers
aurelijus
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCa4d33ef117aa: Use phutil_json_decode instead of json_decode
Summary

Generally, phutil_json_decode should be preferred over json_decode.

Test Plan

Eyeballed.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30443.May 3 2015, 9:14 PM
joshuaspence retitled this revision from to Use phutil_json_decode instead of json_decode.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 9:14 PM
Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript
epriestley accepted this revision.May 3 2015, 9:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 3 2015, 9:14 PM
Closed by commit rARCa4d33ef117aa: Use phutil_json_decode instead of json_decode (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
14 lines
unit/
parser/
7 lines
workflow/
5 lines
2 lines

Diff 30469

View Options

src/lint/linter/ArcanistJSHintLinter.php

Loading...
View Options

src/unit/parser/ArcanistPhpunitTestResultParser.php

Loading...
View Options

src/workflow/ArcanistCallConduitWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility