Paths

Table of Contentst

Differential D12678

Use phutil_json_decode instead of json_decode
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 9:14 PM.

Tags

None

Referenced Files

	F14967762: D12678.id30443.diff
	Sun, Feb 16, 10:07 AM

	Unknown Object (File)
	Tue, Feb 11, 5:02 AM

	Unknown Object (File)
	Sat, Feb 8, 4:15 AM

	Unknown Object (File)
	Sat, Feb 8, 4:14 AM

	Unknown Object (File)
	Sat, Feb 8, 4:14 AM

	Unknown Object (File)
	Sat, Feb 8, 4:14 AM

	Unknown Object (File)
	Thu, Feb 6, 3:53 AM

	Unknown Object (File)
	Tue, Feb 4, 4:31 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCa4d33ef117aa: Use phutil_json_decode instead of json_decode

Summary

Generally, phutil_json_decode should be preferred over json_decode.

Test Plan

Eyeballed.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5704
Build 5723: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	855 ms	ArcanistJSHintLinterTestCase::testLinter
	1,721 ms	ArcanistPuppetLintLinterTestCase::testLinter
	278 ms	ArcanistXMLLinterTestCase::testLinter
	1,941 ms	ArcanistCSSLintLinterTestCase::testLinter
	410 ms	ArcanistCSSLintLinterTestCase::testVersion
		View Full Test Results (3 Failed · 59 Passed · 5 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 30443.May 3 2015, 9:14 PM

joshuaspence retitled this revision from to Use phutil_json_decode instead of json_decode.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 9:14 PM

Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript

epriestley accepted this revision.May 3 2015, 9:14 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 3 2015, 9:14 PM

Closed by commit rARCa4d33ef117aa: Use phutil_json_decode instead of json_decode (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 12:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCSharpLinter.php

2 lines

ArcanistJSHintLinter.php

14 lines

unit/

parser/

ArcanistPhpunitTestResultParser.php

5 lines

workflow/

ArcanistCallConduitWorkflow.php

5 lines

Diff 30443

src/lint/linter/ArcanistCSharpLinter.php

Loading...

src/lint/linter/ArcanistJSHintLinter.php

Loading...

src/unit/parser/ArcanistPhpunitTestResultParser.php

Loading...

src/workflow/ArcanistCallConduitWorkflow.php

Loading...