Fixes T7254. This reverts the previous functionality, but makes pertinent updates like scaling the images to 35 x 35. Codebase had moved on quite a bit so far from a straight revert but nothing too tricky relative to the code that was here before. This does not allow for changing the images from the conpherence durable column view -- that would require some JS trickery, but also doesn't fit into the current notion of the column being "light". Can always modify this later.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7254: Custom Conpherence Image
- Commits
- Restricted Diffusion Commit
rP16ce63ec20cc: Conpherence - add back in custom images
- from full conpherence, uploaded a square pic and things looked nice
- from full conpherence, uploaded a rectangular pic and wasnt happy, so reinvoked edit dialog and used crop control to make it better
- noted could not update picture from conpherence durable column
- used different user and noted could see custom picture
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I'd expect that we'd need to call $file->attachToObject($thread->getPHID()) somewhere, either:
- Explicitly;
- by returning the new images from extractFilePHIDs() in the Editor; or
- by passing viewPHID to the drop upload controller.
Without doing this, I'd expect other users to be unable to see the image because it never gets attached to the thread.