Page MenuHomePhabricator

Calendar event transaction emails without reply handling
ClosedPublic

Authored by lpriestley on May 1 2015, 6:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 11:38 PM
Unknown Object (File)
Fri, May 3, 11:38 PM
Unknown Object (File)
Fri, May 3, 11:38 PM
Unknown Object (File)
Fri, May 3, 11:35 PM
Unknown Object (File)
Fri, May 3, 11:35 PM
Unknown Object (File)
Fri, May 3, 5:23 AM
Unknown Object (File)
Thu, Apr 25, 12:52 AM
Unknown Object (File)
Tue, Apr 16, 1:47 AM
Subscribers

Details

Summary

Ref T7957, Calendar event transaction emails without reply handling.

Test Plan

Create event, invitees should get email.

Diff Detail

Repository
rP Phabricator
Branch
calendareventemails
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5654
Build 5673: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley retitled this revision from to Calendar event transaction emails without reply handling.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/editor/PhabricatorCalendarEventEditor.php
231

For consistency with other applications., prefer [Calendar] (no caps).

234–236

Just leave this unimplemented to use the default (the object's PHID).

Subclasses which override this do so for historical reasons, to avoid breaking existing threads.

258–279

Remove or convert to be consistent with Calendar.

This revision now requires changes to proceed.May 1 2015, 6:44 PM
lpriestley edited edge metadata.

Adding reply handler

lpriestley marked 3 inline comments as done.
lpriestley edited edge metadata.

Cleanup

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 1 2015, 8:24 PM
lpriestley edited edge metadata.

lint pht cleanup

This revision was automatically updated to reflect the committed changes.